Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add trailing commas to Starlark code #218

Merged
merged 5 commits into from
Mar 16, 2023
Merged

Conversation

Peeeekay
Copy link
Contributor

@Peeeekay Peeeekay commented Mar 15, 2023

Description:

Is this change user facing?

  • Yes
  • No

References (if applicable):

Changelog picked up from commits here:

docs: missed one comma
fix: add trailing commas to starlark code

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 15, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: f76c619
Status: ✅  Deploy successful!
Preview URL: https://8285baa2.kurtosis-docs.pages.dev
Branch Preview URL: https://pk-fix-docs-starlark.kurtosis-docs.pages.dev

View logs

@Peeeekay Peeeekay marked this pull request as ready for review March 15, 2023 14:45
@Peeeekay Peeeekay requested a review from leeederek March 15, 2023 14:52
Copy link
Contributor

@leeederek leeederek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me.

@leeederek leeederek enabled auto-merge (squash) March 16, 2023 18:08
@leeederek
Copy link
Contributor

Addresses #187

@leeederek leeederek merged commit 1bd050c into main Mar 16, 2023
@leeederek leeederek deleted the pk/fix-docs-starlark branch March 16, 2023 18:13
h4ck3rk3y pushed a commit that referenced this pull request Mar 16, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.68.13](0.68.12...0.68.13)
(2023-03-16)


### Features

* made the content-type field optional in PostHttpRequestRecipe
([#222](#222))
([d551398](d551398))


### Bug Fixes

* add trailing commas to Starlark code
([#218](#218))
([1bd050c](1bd050c))
* collapse current behavior into background+motivation
([#216](#216))
([853aa5d](853aa5d))
* print the upgrade CLI warning at most hourly
([#224](#224))
([f40ee90](f40ee90))
* refer to the new repo name in remote subpackage tests
([#225](#225))
([cd81f2e](cd81f2e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants